Symlink from /opt/<component>/var/log to /var/log/<component>.
#7999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These symlinks are deprecated with the intent of removing them in ATC 9.0.0.
Symlink support is added in mojohaus/rpm-maven-plugin#42.
zrhoffman
added
Traffic Router
kdamichie
reviewed
Apr 25, 2024
| cp -R * ${RPM_BUILD_ROOT}/%{tomcat_home}/ | ||
| ln -s /var/log/tomcat "${RPM_BUILD_ROOT}"%{tomcat_home}/logs |
There was a problem hiding this comment.
Would a "ln -sf" be a more resilient option here?
There was a problem hiding this comment.
If adding -f ever prevents an error on this line, it means that there was already some file that existed at ${RPM_BUILD_ROOT}/opt/traffic_stats/var/log. We'd rather know that such a file exists than cover up the error, right?
| @@ -49,6 +49,8 @@ mkdir -p "${RPM_BUILD_ROOT}"/opt/traffic_monitor/backup | |||
| mkdir -p "${RPM_BUILD_ROOT}"/opt/traffic_monitor/static | |||
| mkdir -p "${RPM_BUILD_ROOT}"/opt/traffic_monitor/var/run | |||
| mkdir -p "${RPM_BUILD_ROOT}"/var/log/traffic_monitor | |||
| # TODO: The /opt/traffic_monitor/var/log symlink is deprecated and should be removed for ATC 9.0.0. | |||
| ln -s /var/log/traffic_monitor "${RPM_BUILD_ROOT}"/opt/traffic_monitor/var/log | |||
There was a problem hiding this comment.
Would a "ln -sf" be a more resilient option here?
There was a problem hiding this comment.
If adding -f ever prevents an error on this line, it means that there was already some file that existed at ${RPM_BUILD_ROOT}/opt/traffic_monitor/var/log. We'd rather know that such a file exists than cover up the error, right?
zrhoffman
added
the
medium impact
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates symlinks from
/opt/<component>/var/logto/var/log/<component>for the log directories that were moved in #7979. This is useful if you have any code or configuration still referencing/opt/<component>/var/log, because it buys some time to change those references to/var/log/<component>, rather than requiring that everything is changed all at once, whenever you deploy #7979.Because this is intended as a temporary measure, these symlinks are deprecated with the intent of removing them in ATC 9.0.0, assuming there is a release before then that does include the symlinks.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build and install the RPMs, verify the symlinks exist.
cd infrastructure/cdn-in-a-box make traffic_monitor/traffic_monitor.rpm traffic_router/traffic_router.rpm traffic_router/tomcat.rpm traffic_stats/traffic_stats.rpm docker-compose build trafficmonitor trafficrouter trafficstats docker-compose run --rm --no-deps --entrypoint= trafficmonitor ls -l /opt/traffic_monitor/var docker-compose run --rm --no-deps trafficrouter ls -l /opt/traffic_router/var docker-compose run --rm --no-deps --entrypoint= trafficstats ls -l /opt/traffic_stats/varPR submission checklist