Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting partial change from PR 7891. #7929

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

rimashah25
Copy link
Contributor


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Ensure read-only role can perform only GET requests.

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@rimashah25 rimashah25 marked this pull request as ready for review January 30, 2024 19:43
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will approve when test pass.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3d933d0) 29.09% compared to head (150842b) 32.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #7929      +/-   ##
============================================
+ Coverage     29.09%   32.03%   +2.93%     
  Complexity       98       98              
============================================
  Files           605      722     +117     
  Lines         77535    82912    +5377     
  Branches         90      970     +880     
============================================
+ Hits          22558    26558    +4000     
- Misses        52894    54204    +1310     
- Partials       2083     2150      +67     
Flag Coverage Δ
golib_unit 53.84% <ø> (ø)
grove_unit 12.02% <ø> (ø)
t3c_unit 5.88% <ø> (ø)
traffic_monitor_unit 25.47% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 22.08% <100.00%> (-0.01%) ⬇️
traffic_portal_v2 74.39% <ø> (?)
traffic_stats_unit 10.78% <ø> (ø)
unit_tests 29.37% <100.00%> (+3.42%) ⬆️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops regression bug a bug in existing functionality introduced by a new version labels Jan 30, 2024
@zrhoffman zrhoffman merged commit dc9c375 into apache:master Jan 30, 2024
83 checks passed
rimashah25 added a commit that referenced this pull request Jan 30, 2024
@rimashah25 rimashah25 deleted the partial_revert-7891 branch January 30, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants