Remove Perl postinstall script #7841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
Traffic Ops
ocket8888
force-pushed
the
tools/postinstall/remove-perl
branch
from
b3cc7db
to
ffc3b68
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zrhoffman
requested changes
Oct 20, 2023
ocket8888
force-pushed
the
tools/postinstall/remove-perl
branch
from
ffc3b68
to
5fea7b9
Compare
ocket8888
force-pushed
the
tools/postinstall/remove-perl
branch
from
5fea7b9
to
ca5955c
Compare
Yes, you read that right. No, it's not a typo. Traffic Ops will refuse to load a configuration file that gives the Traffic Ops Golang port as an integer instead of a string.
ocket8888
force-pushed
the
tools/postinstall/remove-perl
branch
from
ca5955c
to
9a08095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the Perl implementation of the Postinstall script and updates documentation accordingly. It also removes support for Python 2, including a code-level compatibility; this won't just not try to run with Python 2 by default, it is now syntactically incompatible with that dead language. Also, as Python3.6 is already end-of-life, the requirement is now Python 3.8+ (EOL November 2024, I believe).
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the postinstall tests pass.
PR submission checklist