Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Router DNS zone calculation optimizations #7641

Merged

Conversation

srijeet0406
Copy link
Contributor

This PR is not related to any issue. It optimizes the way Traffic Router (TR) calculates the zone(delivery service) of an incoming reuest.


Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Make sure all the tests pass.
Run TR locally and make DNS/ HTTP requests against it. If the request is of the form routing name.DS FQDN, the resultant delivery service should be returned from the new map that was introduced in this PR.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #7641 (c2e9624) into master (7d5cebe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7641   +/-   ##
=========================================
  Coverage     30.13%   30.13%           
  Complexity       98       98           
=========================================
  Files           794      794           
  Lines         84060    84060           
  Branches        907      907           
=========================================
  Hits          25333    25333           
  Misses        56597    56597           
  Partials       2130     2130           
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ericholguin ericholguin added Traffic Router related to Traffic Router medium impact impacts a significant portion of a CDN, or has the potential to do so performance impacts/improves/measures performance improvement The functionality exists but it could be improved in some way. java Pull requests that update Java or Java-related code labels Jul 12, 2023
@zrhoffman zrhoffman changed the title Tr nxdomain optimization performance Traffic Router DNS zone calculation optimizations Jul 13, 2023
@zrhoffman
Copy link
Member

(this is a re-PR of #7622 with improved performance)

@zrhoffman zrhoffman merged commit 7316c56 into apache:master Jul 13, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement The functionality exists but it could be improved in some way. java Pull requests that update Java or Java-related code medium impact impacts a significant portion of a CDN, or has the potential to do so performance impacts/improves/measures performance Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants