Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To types rfc format #7575

Merged
merged 30 commits into from
Jul 6, 2023
Merged

Conversation

gbkannan89
Copy link
Contributor

@gbkannan89 gbkannan89 commented Jun 12, 2023

Closes: #7496
Related: #5911

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make Api calls to types 5.0

Types to Use RFC3339 Format

  --url https://localhost:8443/api/5.0/types


{ 
  "response": [
      {
          "id": 48,
          "lastUpdated": "2018-12-12T20:49:28.111111Z",
          "name": "TC_LOC",
          "description": "Location for Traffic Control Component Servers",
          "useInTable": "cachegroup"
      }
  ]
}

If this is a bugfix, which Traffic Control versions contained the bug?

  • 7.0.1

PR submission checklist

@gbkannan89 gbkannan89 marked this pull request as ready for review June 13, 2023 17:14
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #7575 (a6b4567) into master (2e995e7) will increase coverage by 1.52%.
The diff coverage is 15.75%.

@@             Coverage Diff              @@
##             master    #7575      +/-   ##
============================================
+ Coverage     27.74%   29.27%   +1.52%     
  Complexity       98       98              
============================================
  Files           686      739      +53     
  Lines         78128    81543    +3415     
  Branches         90      907     +817     
============================================
+ Hits          21675    23869    +2194     
- Misses        54396    55634    +1238     
+ Partials       2057     2040      -17     
Flag Coverage Δ
traffic_ops_integration 78.91% <100.00%> (+9.49%) ⬆️
v3 ?
v4 79.18% <ø> (ø)
v5 78.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/t3c-apply.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/util/gitutil.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/util/util.go 4.82% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.83% <0.00%> (-0.06%) ⬇️
cache-config/t3cutil/t3cutil.go 18.97% <0.00%> (-0.82%) ⬇️
...ental/traffic-portal/src/app/api/server.service.ts 83.49% <ø> (ø)
...al/src/app/api/testing/delivery-service.service.ts 63.00% <ø> (ø)
...affic-portal/src/app/api/testing/server.service.ts 41.25% <0.00%> (ø)
... and 66 more

... and 122 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Jun 13, 2023
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are also missing a changelog entry.

docs/source/api/v5/types.rst Outdated Show resolved Hide resolved
docs/source/api/v5/types.rst Outdated Show resolved Hide resolved
docs/source/api/v5/types_id.rst Outdated Show resolved Hide resolved
lib/go-tc/types.go Outdated Show resolved Hide resolved
traffic_ops/app/admin Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
lib/go-tc/types.go Outdated Show resolved Hide resolved
lib/go-tc/types.go Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/types/types.go Outdated Show resolved Hide resolved
}

query := selectQuery() + where + orderBy + pagination
rows, err := tx.NamedQuery(query, queryValues)

Check failure

Code scanning / CodeQL

Database query built from user-controlled sources High

This query depends on a
user-provided value
.
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested CRUD functionality locally and all works correctly, including RFC3339 timestamp.

@rimashah25
Copy link
Contributor

Need to fix changelog and then we are good to merge.

@rimashah25 rimashah25 merged commit 8a08e3b into apache:master Jul 6, 2023
42 of 44 checks passed
@rimashah25 rimashah25 added this to the 8.0.0 milestone Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Types in TO API uses non-RFC3339 date/time strings
3 participants