Specify nodejs version in TP spec

[shamrickus]

What does this PR (Pull Request) do?

• This PR fixes TP rpmspec does not specify nodejs version #5438

Which Traffic Control components are affected by this PR?

• Traffic Portal

What is the best way to verify this PR?

Build the TP RPM and verify that it depends on Nodejs 12 instead of any nodejs version.

If this is a bug fix, what versions of Traffic Control are affected?

• master

The following criteria are ALL met by this PR

• This PR includes tests OR I have explained why tests are unnecessary
• This PR includes documentation OR I have explained why documentation is unnecessary
• This PR includes an update to CHANGELOG.md OR such an update is not necessary
• This PR includes any and all required license headers
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

[zrhoffman]

Currently the documentation says nodejs 12 or above is required.

trafficcontrol/traffic_portal/build/traffic_portal.spec

Line 28 in f2cb7e1

Requires: nodejs >= 2:12.0.0, nodejs < 2:13.0.0

Does TP not run correctly on Node 13 or above? If so, that should be documented.

[shamrickus]

There's no reason it shouldn't, but I think we want to pin our nodejs to a tested version.

[zrhoffman]

[...] I think we want to pin our nodejs to a tested version.

That's an environment decision. The NodeSource yum repos are separated by Node.js major version (example: https://rpm.nodesource.com/pub_12.x/el/8/x86_64/nodesource-release-el8-1.noarch.rpm), so there's no danger of upgrading an existing nodejs package to a new major version. Since the EPEL nodejs versions for CentOS 7 and CentOS 8 are both under 12 anyway, specifying minimum version only should be sufficient.

[mitchell852]

lgtm