TPv2: Update required node version to >= 18, eslint-plugin-jsdoc (#7933)

* fix: update required node version to >= 18, eslint-plugin-jsdoc * fix: turn off eslint jsdoc rules * enable eslint MethodDefinition * revert: eslint jsdoc * chore: config eslint jsdoc/tag-lines
apache · Feb 7, 2024 · a01d4af · a01d4af
1 parent b7f5774
commit a01d4af
Show file tree

Hide file tree

Showing 6 changed files with 113 additions and 42 deletions.
diff --git a/experimental/traffic-portal/.eslintrc.json b/experimental/traffic-portal/.eslintrc.json
@@ -88,7 +88,7 @@
 				],
 				"id-match": "error",
 				"import/no-deprecated": "warn",
-				"jsdoc/newline-after-description": "error",
+				"jsdoc/tag-lines":  ["error", "any", {"startLines":1}],
 				"max-classes-per-file": "off",
 				"no-caller": "error",
 				"no-cond-assign": "error",

diff --git a/experimental/traffic-portal/build/traffic_portal_v2.spec b/experimental/traffic-portal/build/traffic_portal_v2.spec
@@ -25,7 +25,7 @@ License:  Apache License, Version 2.0
 URL:      https://github.com/apache/trafficcontrol/
 Source:   %{_sourcedir}/traffic-portal-%{traffic_control_version}.tgz
 AutoReqProv: no
-Requires: nodejs >= 2:16.14.0
+Requires: nodejs >= 2:18.0.0
 Requires(pre): /usr/sbin/useradd, /usr/bin/getent
 
 %define traffic_portal_home /opt/traffic-portal

diff --git a/experimental/traffic-portal/package-lock.json b/experimental/traffic-portal/package-lock.json
diff --git a/experimental/traffic-portal/package.json b/experimental/traffic-portal/package.json
@@ -24,7 +24,7 @@
     "Traffic Portal"
   ],
   "engines": {
-    "node": ">=16.14.0"
+    "node": ">=18.0.0"
   },
   "engineStrict": true,
   "scripts": {
@@ -101,7 +101,7 @@
     "cypress": "^13.6.2",
     "eslint": "^8.39.0",
     "eslint-plugin-import": "^2.25.3",
-    "eslint-plugin-jsdoc": "^37.0.3",
+    "eslint-plugin-jsdoc": "^48.0.5",
     "eslint-plugin-prefer-arrow": "^1.2.3",
     "geckodriver": "^3.2.0",
     "jasmine-core": "^3.10.1",

diff --git a/infrastructure/cdn-in-a-box/optional/traffic_portal_v2/Dockerfile b/infrastructure/cdn-in-a-box/optional/traffic_portal_v2/Dockerfile
@@ -31,7 +31,7 @@ RUN if [[ "${RHEL_VERSION%%.*}" -eq 7 ]]; then \
     fi
 
 RUN set -o pipefail && \
-    curl -sLf https://rpm.nodesource.com/setup_16.x | bash
+    curl -sLf https://rpm.nodesource.com/setup_18.x | bash
 
 # Override TRAFFIC_PORTAL_RPM arg to use a different one using --build-arg TRAFFIC_PORTAL_RPM=...  Can be local file or http://...
 ARG TRAFFIC_PORTAL_RPM=traffic_portal_v2/traffic_portal_v2.rpm

diff --git a/infrastructure/cdn-in-a-box/optional/traffic_portal_v2_e2e_test/Dockerfile b/infrastructure/cdn-in-a-box/optional/traffic_portal_v2_e2e_test/Dockerfile
@@ -53,7 +53,7 @@ RUN wget https://dl.google.com/linux/direct/google-chrome-stable_current_x86_64.
 FROM os-dependencies AS node-dependencies
 # Download and install node
 RUN set -o pipefail; \
-    curl -sLf https://rpm.nodesource.com/setup_16.x | bash
+    curl -sLf https://rpm.nodesource.com/setup_18.x | bash
 RUN dnf -y install nodejs || ( \
         # rpm --rebuilddb after installing the nodejs is necessary on docker 20.10.8,
         # build 3967b7d as of 2023-01-19, though that was not always the case for that