Cache the value earlier. Followup to r1809684

git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1809711 13f79535-47bb-0310-9956-ffa450edef68
apache · Sep 26, 2017 · 31e9950 · 31e9950
1 parent e650cf1
commit 31e9950
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/java/org/apache/catalina/webresources/AbstractFileResourceSet.java b/java/org/apache/catalina/webresources/AbstractFileResourceSet.java
@@ -136,12 +136,12 @@ protected final File file(String name, boolean mustExist) {
 
 
     private boolean isInvalidWindowsFilename(String name) {
-        if (name.length() == 0) {
+        final int len = name.length();
+        if (len == 0) {
             return false;
         }
         // This consistently ~10 times faster than the equivalent regular
         // expression irrespective of input length.
-        final int len = name.length();
         for (int i = 0; i < len; i++) {
             char c = name.charAt(i);
             if (c == '\"' || c == '<' || c == '>') {