Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TINKERPOP-3112] Javascript: fix memory leak on server error #2807

Open
wants to merge 2 commits into
base: 3.6-dev
Choose a base branch
from

Conversation

ohana54
Copy link

@ohana54 ohana54 commented Oct 2, 2024

Jira link: https://issues.apache.org/jira/browse/TINKERPOP-3112

This PR fixes a memory leak in the case the server responds with an error.
I observed the leak in our environment, took heap snapshots and traced it down to not removing response handlers in case of a server error.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.41%. Comparing base (d9e34fb) to head (890f761).
Report is 121 commits behind head on 3.6-dev.

Additional details and impacted files
@@              Coverage Diff              @@
##             3.6-dev    #2807      +/-   ##
=============================================
+ Coverage      75.14%   75.41%   +0.26%     
- Complexity     12346    12365      +19     
=============================================
  Files           1058     1033      -25     
  Lines          63610    59901    -3709     
  Branches        6962     6974      +12     
=============================================
- Hits           47801    45173    -2628     
+ Misses         13225    12332     -893     
+ Partials        2584     2396     -188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ohana54 ohana54 changed the title Javascript: fix memory leak on server error [TINKERPOP-3112] Javascript: fix memory leak on server error Oct 2, 2024
@kenhuuu
Copy link
Contributor

kenhuuu commented Oct 2, 2024

Thank you for contributing. Even though this change is small, it would still be best to add an entry to the CHANGELOG.

VOTE+1, pending CHANGELOG entry.

@Cole-Greer
Copy link
Contributor

Thanks for the contribution.

VOTE +1

Just an FYI, our voting process requires 3 votes to merge, or 1 week to pass after a single vote. A committer will merge your PR once it has sufficient votes.

@ohana54 ohana54 force-pushed the fix-js-server-error-mem-leak-3.6 branch 2 times, most recently from 2c90eaa to b054a58 Compare October 8, 2024 20:34
@ohana54 ohana54 force-pushed the fix-js-server-error-mem-leak-3.6 branch from b054a58 to 890f761 Compare October 8, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants