Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIKA-4361 -- follow on fix #2108

Merged
merged 1 commit into from
Jan 28, 2025
Merged

TIKA-4361 -- follow on fix #2108

merged 1 commit into from
Jan 28, 2025

Conversation

tballison
Copy link
Contributor

Thanks for your contribution to Apache Tika! Your help is appreciated!

Before opening the pull request, please verify that

  • there is an open issue on the Tika issue tracker which describes the problem or the improvement. We cannot accept pull requests without an issue because the change wouldn't be listed in the release notes.
  • the issue ID (TIKA-XXXX)
    • is referenced in the title of the pull request
    • and placed in front of your commit messages surrounded by square brackets ([TIKA-XXXX] Issue or pull request title)
  • commits are squashed into a single one (or few commits for larger changes)
  • Tika is successfully built and unit tests pass by running mvn clean test
  • there should be no conflicts when merging the pull request branch into the recent main branch. If there are conflicts, please try to rebase the pull request branch on top of a freshly pulled main branch
  • if you add new module that downstream users will depend upon add it to relevant group in tika-bom/pom.xml.

We will be able to faster integrate your pull request if these conditions are met. If you have any questions how to fix your problem or about using Tika in general, please sign up for the Tika mailing list. Thanks!

@tballison
Copy link
Contributor Author

tballison commented Jan 28, 2025

The corpus file: commoncrawl3/5A/5AODDDRT5BKTJEDN7TENBGKKDO5I3ODD shows why we had to make this fix to the original TIKA-4361 fix. I regret that I can't share the file that triggered the initial modification for TIKA-4361.

@tballison tballison merged commit 05db89d into main Jan 28, 2025
1 check passed
@tballison tballison deleted the TIKA-4361b branch January 28, 2025 16:41
tballison added a commit that referenced this pull request Jan 28, 2025
(cherry picked from commit 05db89d)
tballison added a commit that referenced this pull request Jan 28, 2025
(cherry picked from commit 05db89d)
sunluman pushed a commit to sunluman/tika that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant