Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEZ-4536: Drop .txt suffix from LICENSE.txt and NOTICE.txt files #330

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

zabetak
Copy link
Member

@zabetak zabetak commented Jan 24, 2024

The .txt suffix is not forbidden however the preferred/suggested naming (https://www.apache.org/legal/apply-license.html#license-file-name) excludes suffix from LICENSE and NOTICE files.

Renamed using the following commands:

for i in `find . -name "NOTICE.txt"`; do mv $i "${i%.*}"; done
for i in `find . -name "LICENSE.txt"`; do mv $i "${i%.*}"; done

The .txt suffix is not forbidden however the preferred/suggested naming
(https://www.apache.org/legal/apply-license.html#license-file-name)
excludes suffix from LICENSE and NOTICE files.
@abstractdog abstractdog self-requested a review January 24, 2024 10:41
Copy link
Contributor

@abstractdog abstractdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tez-yetus

This comment was marked as outdated.

@tez-yetus

This comment was marked as outdated.

@tez-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 10s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 36 new or modified test files.
_ master Compile Tests _
+0 🆗 mvndep 5m 38s Maven dependency ordering for branch
+1 💚 mvninstall 8m 8s master passed
+1 💚 javadoc 3m 47s master passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 3m 53s master passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Patch Compile Tests _
+0 🆗 mvndep 0m 7s Maven dependency ordering for patch
+1 💚 mvninstall 6m 4s the patch passed
+1 💚 shellcheck 0m 0s There were no new shellcheck issues.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 javadoc 3m 33s the patch passed with JDK Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04
+1 💚 javadoc 4m 0s the patch passed with JDK Private Build-1.8.0_392-8u392-ga-1~22.04-b08
_ Other Tests _
+1 💚 unit 2m 1s tez-api in the patch passed.
+1 💚 unit 0m 28s tez-common in the patch passed.
+1 💚 unit 0m 37s tez-runtime-internals in the patch passed.
+1 💚 unit 4m 20s tez-runtime-library in the patch passed.
+1 💚 unit 1m 7s tez-mapreduce in the patch passed.
+1 💚 unit 0m 19s tez-examples in the patch passed.
+1 💚 unit 4m 19s tez-dag in the patch passed.
+1 💚 unit 37m 2s tez-tests in the patch passed.
+1 💚 unit 1m 1s tez-ui in the patch passed.
+1 💚 unit 1m 28s tez-yarn-timeline-history in the patch passed.
+1 💚 unit 0m 18s tez-yarn-timeline-cache-plugin in the patch passed.
+1 💚 unit 1m 29s tez-yarn-timeline-history-with-fs in the patch passed.
+1 💚 unit 0m 17s tez-dist in the patch passed.
+1 💚 unit 62m 54s root in the patch passed.
+1 💚 asflicense 3m 44s The patch does not generate ASF License warnings.
158m 42s
Subsystem Report/Notes
Docker ClientAPI=1.44 ServerAPI=1.44 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/artifact/out/Dockerfile
GITHUB PR #330
JIRA Issue TEZ-4536
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit
uname Linux 71e9a32d8d6e 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/tez.sh
git revision master / 5a2df54
Default Java Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.21+9-post-Ubuntu-0ubuntu122.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_392-8u392-ga-1~22.04-b08
Test Results https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/testReport/
Max. process+thread count 2100 (vs. ulimit of 5500)
modules C: tez-api tez-common tez-runtime-internals tez-runtime-library tez-mapreduce tez-examples tez-dag tez-tests tez-ui tez-plugins/tez-yarn-timeline-history tez-plugins/tez-yarn-timeline-cache-plugin tez-plugins/tez-yarn-timeline-history-with-fs tez-dist . U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-330/3/console
versions git=2.34.1 maven=3.6.3 shellcheck=0.7.1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@abstractdog abstractdog merged commit 5b4e827 into apache:master Jan 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants