improve helm chart #9346

fbalicchia · 2020-03-22T08:46:49Z

SUMMARY

Improve Superset chart

ADDITIONAL INFORMATION

Hi please review my PR, with this PR I've add possibility to

Configure superset_config.py in values using configmap
Enable/disable Postgres and Redis deploy
Possibility to add postStart hook for Superset config like create user etc.ect

This is for SupersetNode I will working soon on worker.

Thanks for your great work

codecov-io · 2020-03-22T10:27:50Z

Codecov Report

Merging #9346 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #9346   +/-   ##
=======================================
  Coverage   58.96%   58.96%           
=======================================
  Files         374      374           
  Lines       12137    12137           
  Branches     2992     2992           
=======================================
  Hits         7156     7156           
  Misses       4802     4802           
  Partials      179      179

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccf21f6...d791822. Read the comment docs.

* [config] Fixing GET_FEATURE_FLAGS_FUNC example * Adding typing for GET_FEATURE_FLAGS_FUNC * Update config.py

* [SQLLAB] add checkbox to control autocomplete * autocomplete -> autocompleteEnabled * fix defaultProps * fix spec

* controls migrated * linting

* migrating unique controls * Lint ✨

* Treemap * linting

* feat: [explore] don't save filters inherited from a dashboard When navigating to explore from a dashboard context, the current dashboard filter(s) are passed along to explore so that the context is kept. So say you're filtering on "country=Romania", in your dashboard and pivot to explore, that filter is still there and keep on exploring. Now a common issue is that you'll want to make some tweak to your chart that are unrelated to the filter, say toggling the legend off for instance, and then save it. Now you back to your dashboard and even though you started with an "all countries" dashboard, with a global filter on country, now that one chart is stuck on "Romania". Typically you notice this when filtering on something else, say "Italy" and then that one chart now has two mutually exclusive filters, and show "No data". Now, the fix is to flag the filter as "extra" (that's the not-so-good internal name we use for these inherited filters) and make it clear that that specific filter is special and won't be saved when saving the chart. * fix build

* [charts] Refactor charts API using SIP-35 * [charts] Fix, copy pasta * [charts] simplify

* [dataset] columns and metrics API (nested) * [dataset] tests and validation * [datasets] Fix, revert list field name to database_name

* Adding requirements-local.txt support * Reverting package-lock.json

* Migrate Heatmap controls * Lint

…mal point (#9351)

* [explore view] fix long query issue from Run in SQL LAB Button * SQL Lab page needs to take the post form data, too * fix variable names * updated payload dict, rename hidden form Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* migrating controls * Linting ✨ * oops... meant to pull this out in a conflict resolution.

Include superset-frontent/package.json in package because setup.py requires it

craig-rueda · 2020-03-26T15:31:51Z

install/helm/superset/templates/deployment.yaml

+    {{- end }}
+          lifecycle:
+    {{- if .Values.supersetNode.hooks.postStart }}
+            postStart:


Rather than using k8s hooks on the deployment level, you should instead spin a Job up which runs the init script. That way, users can safely tune their replica count up/down without re-triggering the init.

Thanks, Jobs in Kubernetes will run to completion once they are created. I' will make configurable enable/disable of init job and in the init containers of job image I'll wait for db Do you see any drawback ?

If a job fails another instance will be created until the job is completed or max retries reached. I think if the job fails because the database could not be reached and a new instance created after, this could be an alternative to adding logic in the container for waiting on db to be ready.

craig-rueda · 2020-03-26T15:33:39Z

install/helm/superset/templates/configmap.yaml

@@ -24,4 +24,14 @@ metadata:
    release: {{ .Release.Name }}
    heritage: {{ .Release.Service }}
 data:
-{{ (.Files.Glob "config/*").AsConfig | indent 2 }}
+  {{- $defaultConf := .Files.Get "files/superset_config.py" |  nindent 4 }}
+  superset_config.py: |-


This config should really be in a secret. Although the current config has nothing "secret" in it, if a user were to try and use this in a production-like environment, they would likely have secrets in their configs

Also, pipe the outputs to tpl so that end users can use template syntax in their overrides

craig-rueda · 2020-03-26T15:35:58Z

install/helm/superset/values.yaml

+
+    ## (string) Script to execute after the client pod starts.
+    postStart: |-
+      #!/usr/bin/env bash


Maybe drop this in a script inside the files folder?

* [dashboard] handle markdown error * localize error message, fix review comments.

Co-authored-by: John Bodley <john.bodley@airbnb.com>

* proto module * caught a missed 'freq' unique control * line_interpolation * linting * showLegend * show_controls * xAxisLabel * bottomMargin * x_ticks_layout * missed one * x_axis_format * yLogScale * y_axis_bounds * linting * nixing yarn lock * x_axis_showminmax * xAxisShowminmax control * richTooltip * linting, syntax fix * show_bar_value, bar_stacked * reduceXticks, yaxislabel * left_margin, max_bubble_size, y_axis_showminmax * show_labels * send_time_range, y_axis_2_format, show_markers, order_bars * nixing commented imports * fake controls * looking up actual controls for comparison. * adding key to test setup * controls inventory * apache junk * lint ✨ * ignore null controls * fixing goofed up spread operation for xAxisFormat config * lint ✨ * fixes for errors caused by <hr> element in filterbox controls * fixing filter controls for 'druid_time_origin', 'granularity', 'granularity_sqla', 'time_grain_sqla' * getControlsInventory -> getControlsForVizType * further renaming of chartControlsInventory - > getControlsForVizType Co-authored-by: David Aaron Suddjian <aasuddjian@gmail.com>

* fix: Add deprecated fields to QueryObject schema * linting

Co-authored-by: John Bodley <john.bodley@airbnb.com>

* Re-enable the AnnotationLayerModelView read API * Fix CI

Co-authored-by: John Bodley <john.bodley@airbnb.com>

* [Build] moves prettier check to separate script * rename step: eslint -> lint

* Add documentation build to Github Actions * Update requirements for documentation builds * Minor optimization - only install requirements for documentation in documentation job

* add statsd to charts api * update test for charts api * [charts] add statsd asserts wrapper * [charts] update api test * removed white space

* [charts] adds new filters ui * move null check to be more visible * better filter lists and async filter functionality

craig-rueda · 2020-04-21T22:35:50Z

@fbalicchia - can you rebase with master? Looks like GH Actions are stuck. I will merge once status is reporting properly...

…et into helm_improve

fbalicchia · 2020-04-22T07:58:29Z

Thanks, @craig-rueda rebase done. but I think that at moment of writing master is stuck too,
Please tell me if I can do something else

improve helm chart

83b67f8

pull-request-size bot added the size/L label Mar 22, 2020

add Apache license headers

d791822

villebro and others added 21 commits March 22, 2020 22:31

fix: suburst chart when secondary metric is defined (#9343)

5e6662a

refactor: remove settooltip (#9332)

f4087d2

[config] Fixing GET_FEATURE_FLAGS_FUNC example (#9339)

5d98575

* [config] Fixing GET_FEATURE_FLAGS_FUNC example * Adding typing for GET_FEATURE_FLAGS_FUNC * Update config.py

feat: [SQLLAB] add checkbox to control autocomplete (#9338)

866f6f9

* [SQLLAB] add checkbox to control autocomplete * autocomplete -> autocompleteEnabled * fix defaultProps * fix spec

Cal heatmap controls migration (#9355)

20dd418

* controls migrated * linting

migrating unique EventFlow controls (#9358)

b5a9bae

* migrating unique controls * Lint ✨

Treemap controls migration (#9352)

3d738ee

* Treemap * linting

[charts] Refactor API using SIP-35 (#9329)

f51ab59

* [charts] Refactor charts API using SIP-35 * [charts] Fix, copy pasta * [charts] simplify

Add global install of webpack and webpack-cli to docker-compose (#9310)

46e39d1

[dataset] columns and metrics API (nested) (#9268)

ccb22dc

* [dataset] columns and metrics API (nested) * [dataset] tests and validation * [datasets] Fix, revert list field name to database_name

Adding requirements-local.txt support (#9357)

06e0f04

* Adding requirements-local.txt support * Reverting package-lock.json

Migrate unique Heatmap controls (#9360)

fe53555

* Migrate Heatmap controls * Lint

fix: don't parseFloat when the *already numeric* value ends in a deci…

634b440

…mal point (#9351)

[sip-15] Fixing typo in docstring (#9377)

43f0221

fix a typo in set prop value (#9383)

4fd5ac9

Migrating unique DirectedForce controls (#9359)

0061a3e

* migrating controls * Linting ✨ * oops... meant to pull this out in a conflict resolution.

Update MANIFEST.in (#9261)

9eb5bad

Include superset-frontent/package.json in package because setup.py requires it

fix: [dashboard] add row padding (#9381)

f5cc0ef

Removing WordCloud controls from CONTRIBUTING.md (#9391)

d5e2f7e

craig-rueda requested changes Mar 26, 2020

View reviewed changes

Grace Guo and others added 4 commits March 26, 2020 09:06

[dashboard] handle markdown error (#9350)

5b07c8d

* [dashboard] handle markdown error * localize error message, fix review comments.

[cache] Cleaning up viz/cache logic (#9375)

19da904

Co-authored-by: John Bodley <john.bodley@airbnb.com>

migrating controls 🎛 (#9386)

bf0fa84

Migrating unique Table controls (#9388)

7e86e38

rusackas and others added 5 commits April 17, 2020 11:40

fix: Add deprecated fields to QueryObject schema (#9579)

0472c11

* fix: Add deprecated fields to QueryObject schema * linting

[mypy] Enforcing typing for superset.migrations (#9583)

636ee5d

Co-authored-by: John Bodley <john.bodley@airbnb.com>

Re-enable the AnnotationLayerModelView read API (#9443)

06471f5

* Re-enable the AnnotationLayerModelView read API * Fix CI

[config] Enable dashboard bootstrap payload reduction by default (#9585)

083dd6a

fbalicchia requested a review from craig-rueda April 20, 2020 05:46

dpgaspar and others added 10 commits April 20, 2020 15:48

[docs] fix, elastic.co elasticsearch product location (#9598)

2295999

[fix] Fixing issue with Jinja filter_value (#9582)

237ac59

Co-authored-by: John Bodley <john.bodley@airbnb.com>

[Build] moves prettier check to separate script (#9591)

cb51d78

* [Build] moves prettier check to separate script * rename step: eslint -> lint

Add documentation build to Github Actions (#9569)

132d774

* Add documentation build to Github Actions * Update requirements for documentation builds * Minor optimization - only install requirements for documentation in documentation job

Add raw number/integer option to d3 number formats (#9562)

2b957a2

Bump superset-ui-connection to 0.12.22 (#9602)

ba691d3

[charts] feat: add statsd to charts api (#9571)

7cefc89

* add statsd to charts api * update test for charts api * [charts] add statsd asserts wrapper * [charts] update api test * removed white space

[tests] Helper script to run single tests (#9547)

9cf33e9

[charts] adds new filters ui (#9530)

0b999e3

* [charts] adds new filters ui * move null check to be more visible * better filter lists and async filter functionality

[SQL Lab] Lock result set controls to be always visible (#9587)

dcbffed

craig-rueda approved these changes Apr 21, 2020

View reviewed changes

fbalicchia added 7 commits April 22, 2020 09:45

improve helm chart

36dc684

add Apache license headers

4aa8fb2

add initjob conf + secret

1bfa6e4

add missing headers

5ba624b

apply changes

0600709

opps again .... license

c2dc9b2

Merge branch 'helm_improve' of github.com:fbalicchia/incubator-supers…

003d273

…et into helm_improve

craig-rueda merged commit d052f47 into apache:master Apr 22, 2020

fbalicchia deleted the helm_improve branch April 25, 2020 06:38

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 labels Feb 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve helm chart #9346

improve helm chart #9346

fbalicchia commented Mar 22, 2020

codecov-io commented Mar 22, 2020

craig-rueda Mar 26, 2020

fbalicchia Mar 27, 2020

garfieldcoked Apr 8, 2020

craig-rueda Mar 26, 2020

craig-rueda Mar 26, 2020

craig-rueda Mar 26, 2020

craig-rueda commented Apr 21, 2020

fbalicchia commented Apr 22, 2020 •

edited

Loading

improve helm chart #9346

improve helm chart #9346

Conversation

fbalicchia commented Mar 22, 2020

CATEGORY

SUMMARY

ADDITIONAL INFORMATION

codecov-io commented Mar 22, 2020

Codecov Report

craig-rueda Mar 26, 2020

Choose a reason for hiding this comment

fbalicchia Mar 27, 2020

Choose a reason for hiding this comment

garfieldcoked Apr 8, 2020

Choose a reason for hiding this comment

craig-rueda Mar 26, 2020

Choose a reason for hiding this comment

craig-rueda Mar 26, 2020

Choose a reason for hiding this comment

craig-rueda Mar 26, 2020

Choose a reason for hiding this comment

craig-rueda commented Apr 21, 2020

fbalicchia commented Apr 22, 2020 • edited Loading

fbalicchia commented Apr 22, 2020 •

edited

Loading