[SIP-36] Migrate Link.jsx to Link.tsx

[etr2460]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

This is an example PR for migrating a React component from JSX to TSX. I performed the following steps:

1. Rename the component file from Link.jsx => Link.tsx
2. Install typedefs for imported libraries (ex. npm install @types/react-bootstrap) or add // @ts-ignore if no valid typedefs exist
3. Replace the propTypes const with an interface Props definition
4. Move default props into the default arguments within the React component
5. Resolve any type errors that may have been exposed by the migration
6. Attach before/after screenshots to the PR to ensure the component functionality remains the same

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TEST PLAN

CI and unit tests, confirm the Link component in SQL Lab renders as expected

ADDITIONAL INFORMATION

• Has associated issue: [SIP-36] Proposal for standardizing use of TypeScript #9101
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

to: @graceguo-supercat @nytai @rusackas @kristw

[nytai]

LGTM!

Looks like tslint is causing travis to fail, ++ for deprecating it in favor of eslint

[nytai]

also, I've noticed that tslint doesn't seem to run as part of lint-fix

./node_modules/.bin/tslint -c ./tslint.json --fix ./{src,spec}/**/*.ts{,x}

is how I've been getting around it.

[etr2460]

@nytai is deprecating tslint in favor of eslint something you can take on? I think we're all pretty much in agreement that it's the right move

[nytai]

@etr2460 sure, I'll give it a try tomorrow