[query] deprecate can_only_access_owned_queries #9046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9046 +/- ##
==========================================
+ Coverage 59.16% 59.45% +0.29%
==========================================
Files 367 369 +2
Lines 11680 11747 +67
Branches 2863 2888 +25
==========================================
+ Hits 6910 6984 +74
+ Misses 4591 4584 -7
Partials 179 179
Continue to review full report at Codecov.
|
willbarrett
reviewed
Jan 29, 2020
willbarrett
reviewed
Jan 29, 2020
superset/security/manager.py
Outdated
| @@ -538,11 +536,10 @@ def create_custom_permissions(self) -> None: | |||
| """ | |||
| Create custom FAB permissions. | |||
| """ | |||
|
|
|||
| self.add_permission_view_menu("all_datasource_access", "all_datasource_access") | |||
| self.add_permission_view_menu("all_database_access", "all_database_access") | |||
| self.add_permission_view_menu( | |||
There was a problem hiding this comment.
Why is creating the permission tied to the concept of a view and the concept of a menu?
willbarrett
reviewed
Jan 29, 2020
michellethomas
approved these changes
Jan 30, 2020
|
@graceguo-supercat it would be awesome if you could take a look |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Proposal to deprecate
can_only_access_owned_queriesin favor of the newall_query_accessThe default changes from:
to:
Adminusers.all_query_accesscan be added to existing roles giving their corresponding user's access to everyone's queriesRunning
superset initis required to create the new permissionADDITIONAL INFORMATION
REVIEWERS
@willbarrett