Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redis cache hint to docs #861

Merged
merged 1 commit into from
Aug 2, 2016
Merged

add redis cache hint to docs #861

merged 1 commit into from
Aug 2, 2016

Conversation

linroex
Copy link
Contributor

@linroex linroex commented Jul 30, 2016

If use Redis as cache server, Flask-Cache will say driver not found, user need manual install python-redis library, so I add hint text into docs

Ref.
Flask-cache redis cache failed

@coveralls
Copy link

coveralls commented Jul 30, 2016

Coverage Status

Coverage remained the same at 81.023% when pulling 886a160 on linroex:master into 299e31f on airbnb:master.

@xrmx
Copy link
Contributor

xrmx commented Jul 31, 2016

Strangely enough it's not documented on flask-cache, cannot hurt to have it there though :)

@linroex
Copy link
Contributor Author

linroex commented Aug 1, 2016

I think it is important, because flask-cache say redis is builtin, but if fact you need install python-redis, like Memcached, many people will feel adoubt (ex. me)

@mistercrunch
Copy link
Member

Thanks for the clarification. We use memcache but the 1M limits and workarounds are a bit annoying... Maybe we should go with Redis.

@mistercrunch mistercrunch merged commit 862042b into apache:master Aug 2, 2016
@rhunwicks
Copy link
Contributor

Note that in order to use a Redis cache with Superset you need to pip install redis. There is actually another package called python_redis and if you do pip install python-redis you get the wrong one. The hint that is now in the docs has the correct link, but might confuse people because it says "please install
 python-redis". It would be better if it said "please install the redis Python package." or similar.

@xrmx
Copy link
Contributor

xrmx commented Apr 5, 2017

@rhunwicks feel free to open a PR

zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* test: use stable random for stories

* Seed with superset-ui

* Add tests for random
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* test: use stable random for stories

* Seed with superset-ui

* Add tests for random
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* test: use stable random for stories

* Seed with superset-ui

* Add tests for random
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* test: use stable random for stories

* Seed with superset-ui

* Add tests for random
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants