Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Live query validation in the SQL Lab UI #7461

Merged
merged 2 commits into from
May 6, 2019
Merged

feat: Live query validation in the SQL Lab UI #7461

merged 2 commits into from
May 6, 2019

Commits on May 6, 2019

  1. [WIP] Live query validation, where supported 

    This builds on apache#7422 to build check-as-you-type sql
query validation in Sql Lab. This closes apache#6707 too.

It adds a (debounced) call to the validate_sql_json
API endpoint with the querytext, and on Lyft infra is
able to return feedback to the user (end to end) in
$TBD seconds.

At present feedback is provided only through the
"annotations" mechanism build in to ACE, although
I'd be open to adding full text elsewhere on the
page if there's interest.
    Alex Berghage committed May 6, 2019
    Configuration menu
    Copy the full SHA
    b802506 View commit details
    Browse the repository at this point in the history

  2. fix: Unbreak lints and tests

    Alex Berghage committed May 6, 2019
    Configuration menu
    Copy the full SHA
    ef69a52 View commit details
    Browse the repository at this point in the history