Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Autorefresh Settings Persist #718

Closed

Conversation

alanmcruickshank
Copy link
Contributor

In response to Issue 686

Adds settings to save and persist dashboard refresh interval and also whether to force refreshing from cache or not. Modal on the Dashboard is changed to allow any value of seconds rather than only the dropdown values.

Pre-existing dashboards (and the defaults for new dashboards) are that the dashboard will refresh using cached values and that initially it won't refresh (interval = 0).

For the values on a dashboard to actually change you should set the cache to expire on a suitable timescale either at the slice level (or higher up the tree).

Includes a fix to migration 27ae655e4247 so that it now uses declarative base to allow the addition of new columns to the model. (@mistercrunch this continues our discussion from this pull request).

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage increased (+0.02%) to 81.059% when pulling 17d56b5a11152b0e8168bf3c240033327aa65558 on alanmcruickshank:autorefresh-dashboard-2 into 8135c24 on airbnb:master.

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage increased (+0.02%) to 81.059% when pulling e10b82e49e431b71ed08d47fbf6591c043ed9bea on alanmcruickshank:autorefresh-dashboard-2 into 8135c24 on airbnb:master.

@alanmcruickshank
Copy link
Contributor Author

Will rebase and resubmit on a tidier branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants