Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update time filter to use react-datetime #5819

Merged
merged 5 commits into from
Sep 10, 2018
Merged

Update time filter to use react-datetime #5819

merged 5 commits into from
Sep 10, 2018

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Sep 5, 2018 •
edited
Loading

I've updated the time filter to use react-datetime, since react-bootstrap-datetimepicker was deprecated and doesn't work with React 16. Overall the new API is better — we no longer need to use refs to handle strings that are not parsed by moment.js, eg.

I also cleaned the code a little bit, moving all the binds out of the render method.

screen shot 2018-09-04 at 8 32 59 pm

@betodealmeida betodealmeida mentioned this pull request Sep 5, 2018
Merged
@codecov-io
Copy link

codecov-io commented Sep 5, 2018 •
edited
Loading

Codecov Report

Merging #5819 into master will decrease coverage by 0.08%.
The diff coverage is 27.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5819      +/-   ##
==========================================
- Coverage   63.73%   63.65%   -0.09%     
==========================================
  Files         368      368              
  Lines       23221    23255      +34     
  Branches     2600     2606       +6     
==========================================
+ Hits        14801    14804       +3     
- Misses       8405     8438      +33     
+ Partials       15       13       -2
Impacted Files Coverage Δ
.../src/explore/components/controls/HiddenControl.jsx 90% <ø> (ø) ⬆️
.../explore/components/controls/DateFilterControl.jsx 48.25% <27.38%> (-12.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299e20a...f11fc68. Read the comment docs.

@betodealmeida
Copy link
Member Author

This actually needs a bit more work — the state handling is broken. Working on it.

williaster
williaster reviewed Sep 5, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @betodealmeida and to unblock react 16!

looking great overall, just wanted to note that you could improve perf stuff further by defining bound functions for all of the myProp={() => this.setState(...) } calls

@mistercrunch mistercrunch merged commit 6c9be9d into apache:master Sep 10, 2018
@mistercrunch mistercrunch deleted the DPTOOLS-1061 branch September 10, 2018 17:27
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
8354eea 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
f992455 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
ded78d0 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
39b9de3 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
9f724a3 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Sep 21, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
7522ff1 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
66c64d9 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 11, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
bfefeb3 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
0401046 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
db1fd47 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
025f26d 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
11b6a67 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
739f8e2 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
0017352 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Oct 17, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
069a44b 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
mistercrunch pushed a commit to lyft/incubator-superset that referenced this pull request Oct 29, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
955b9fa 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
fda9d16 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
2df7d38 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
e5bcb4d 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
4def808 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
betodealmeida added a commit to lyft/incubator-superset that referenced this pull request Oct 30, 2018
@betodealmeida
Update time filter to use react-datetime (apache#5819)
0a13188 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
1ff2910 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
youngyjd pushed a commit to lyft/incubator-superset that referenced this pull request Nov 2, 2018
@betodealmeida @youngyjd
Update time filter to use react-datetime (apache#5819)
5bc8bfa 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things

(cherry picked from commit 6c9be9d)
(cherry picked from commit ded78d0)
(cherry picked from commit bfefeb3)
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@betodealmeida @mistercrunch
Update time filter to use react-datetime (apache#5819)
7632e9d 
* Update time filter to use react-datetime

* Clean up code

* Many small fixes and improvements

* Fix small things
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @codecov-io @williaster @mistercrunch