Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing multiple values for the same parameter name #565

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

Marigold
Copy link
Contributor

@Marigold Marigold commented Jun 4, 2016

Multiple parameters from forms (e.g. all_columns in Table View) get lost in get_url function and only the first one is kept. This happens when you try to save Table View as csv. Switching from OrderedDict to MultiDict does the trick.

  • make the tests pass

@mistercrunch
Copy link
Member

Awesome!

@mistercrunch mistercrunch merged commit 1631137 into apache:master Jun 11, 2016
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 2.2.0 to 3.0.0.
- [Release notes](https://github.com/tschaub/gh-pages/releases)
- [Changelog](https://github.com/tschaub/gh-pages/blob/master/changelog.md)
- [Commits](tschaub/gh-pages@v2.2.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 2.2.0 to 3.0.0.
- [Release notes](https://github.com/tschaub/gh-pages/releases)
- [Changelog](https://github.com/tschaub/gh-pages/blob/master/changelog.md)
- [Commits](tschaub/gh-pages@v2.2.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 2.2.0 to 3.0.0.
- [Release notes](https://github.com/tschaub/gh-pages/releases)
- [Changelog](https://github.com/tschaub/gh-pages/blob/master/changelog.md)
- [Commits](tschaub/gh-pages@v2.2.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Bumps [gh-pages](https://github.com/tschaub/gh-pages) from 2.2.0 to 3.0.0.
- [Release notes](https://github.com/tschaub/gh-pages/releases)
- [Changelog](https://github.com/tschaub/gh-pages/blob/master/changelog.md)
- [Commits](tschaub/gh-pages@v2.2.0...v3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants