Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python3 version for testing to 3.6 #5562

Merged
merged 3 commits into from
Aug 7, 2018
Merged

update python3 version for testing to 3.6 #5562

merged 3 commits into from
Aug 7, 2018

Conversation

octaviancorlade
Copy link
Contributor

Python 3.4 is not supported and since #4835 python 3.6 is used for testing in Travis

@octaviancorlade octaviancorlade changed the title update python version for testing to 3.6 update python3 version for testing to 3.6 Aug 4, 2018
CONTRIBUTING.md Outdated
@@ -65,7 +65,7 @@ meets these guidelines:
3. If the pull request adds functionality, the docs should be updated
as part of the same PR. Doc string are often sufficient, make
sure to follow the sphinx compatible standards.
4. The pull request should work for Python 2.7, and ideally Python 3.4+.
4. The pull request should work for Python 2.7, and ideally Python 3.5+.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 3.6 here.

@mistercrunch
Copy link
Member

SGTM, we should go full on 3.6 soon. I think it's important for libraries to support a wide array of version, but since Superset is a full on product, people can set it up using 3.6.

Maybe we should write a SIP (Superset Improvement Proposal) about it.

@codecov-io
Copy link

codecov-io commented Aug 4, 2018

Codecov Report

Merging #5562 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5562   +/-   ##
=======================================
  Coverage   63.23%   63.23%           
=======================================
  Files         351      351           
  Lines       22258    22258           
  Branches     2470     2470           
=======================================
  Hits        14075    14075           
  Misses       8168     8168           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b7ca0...9a6335d. Read the comment docs.

@octaviancorlade
Copy link
Contributor Author

Updated, a bit unsure about that plus sign in "Python 3.6+" at this point.
Also, setup.py (and therefore pypi) still lists both 3.5 and 3.6.

@john-bodley john-bodley merged commit 39ff9de into apache:master Aug 7, 2018
@octaviancorlade octaviancorlade deleted the docs-update-python-version branch August 8, 2018 06:51
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* update python version for testing to 3.6

* CONTRIBUTING.md states pull requests should work on py27, py36+

* CONTRIBUTING.md states pull requests should work on py27 and py36
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants