[bufix] filtered column was removed #4921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here.
Codecov Report
@@ Coverage Diff @@
## master #4921 +/- ##
=======================================
Coverage 77.12% 77.12%
=======================================
Files 44 44
Lines 8539 8539
=======================================
Hits 6586 6586
Misses 1953 1953
Continue to review full report at Codecov.
|
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
May 2, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
|
It could get a little confusing if the filter remains in the form data but gets disregarded in the backend. It would look like the filter is still getting applied but it's actually the case the field doesn't exist. What about just showing a better error message (a prompt to remove the filter)? |
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
May 16, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
|
Yes there should be a validator on the |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "&apache#39;NoneType&apache#39; object has no attribute &apache#39;is_num&apache#39;" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here.
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
May 30, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
May 30, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "&apache#39;NoneType&apache#39; object has no attribute &apache#39;is_num&apache#39;" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here.
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 4, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 7, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Jun 27, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "'NoneType' object has no attribute 'is_num'" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here. (cherry picked from commit e213ccd)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
if a filter is created on a chart, and the column is removed from the dataset, you get a "&apache#39;NoneType&apache#39; object has no attribute &apache#39;is_num&apache#39;" or something to that effect. This fix disregards the filter. Also error messages were HTML escaped which React does already anyways so that's not necessary [anymore] here.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a filter is created on a chart, and the column is removed from the
dataset, you get a "'NoneType' object has no attribute
'is_num'" or something to that
effect. This fix disregards the filter.
Also error messages were HTML escaped which React does already anyways
so that's not necessary [anymore] here.