Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages.json #3716

Merged
merged 2 commits into from
Nov 8, 2017
Merged

Update messages.json #3716

merged 2 commits into from
Nov 8, 2017

Conversation

magicansk
Copy link
Contributor

No description provided.

@xrmx
Copy link
Contributor

xrmx commented Oct 25, 2017

Please don't open a new PR for each file you want to update. Especially if you are duplicating work already done.

@coveralls
Copy link

coveralls commented Oct 25, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 7c2e126 on magicansk:patch-2 into 547a3bf on apache:master.

@xrmx
Copy link
Contributor

xrmx commented Oct 25, 2017

You already opened two PR when it should have been one at most :) and how is this not duplicate work of #3174 since you are touching the very same files?

@magicansk
Copy link
Contributor Author

Well, I didn't notice that I commit the "very" same files as you said. For different files, there is the different part that has been translating. But I think what you wanna said is for Chinese translation part reference to the earlier PR.
for #3714 superset/connectors/druid/models.py
for #3715 superset/translations/zh/LC_MESSAGES/messages.po
for #3716 superset/translations/zh/LC_MESSAGES/messages.json

@coveralls
Copy link

coveralls commented Oct 26, 2017

Coverage Status

Coverage remained the same at 71.352% when pulling 92434a1 on magicansk:patch-2 into 547a3bf on apache:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 92434a1 on magicansk:patch-2 into 547a3bf on apache:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.352% when pulling 92434a1 on magicansk:patch-2 into 547a3bf on apache:master.

@mistercrunch mistercrunch merged commit 7453131 into apache:master Nov 8, 2017
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Update messages.json

* Update messages.json
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Update messages.json

* Update messages.json
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.21.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants