Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the slice permission issue after user click-edit new slice title #3711

Merged

Conversation

graceguo-supercat
Copy link

step to reproduce:

  1. user start visualize a query from sql lab, and landing in explore view. At this time the title of visualized query is default to undefined - untitled
  2. user click the slice title and change slice title.
  3. then user clicks 'Save' button on upper left page, so that Save a Slice modal will show up.
  4. when user save slice by using modal, they will see 'You don't have right to change this slice' message.

The root cause here is when user click-edit new query data, we save the query as new slice, but in the responses, should use updated form_data which was generated after slice was created. Otherwise we missed new slice_id in the form_data response data.

@coveralls
Copy link

coveralls commented Oct 24, 2017

Coverage Status

Coverage remained the same at 70.744% when pulling aeb33a5 on graceguo-supercat:gg-FixEditNewSliceTitle into 58ea736 on apache:master.

@michellethomas
Copy link
Contributor

lgtm

@graceguo-supercat graceguo-supercat merged commit 4967342 into apache:master Oct 24, 2017
@graceguo-supercat graceguo-supercat deleted the gg-FixEditNewSliceTitle branch October 24, 2017 21:42
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants