Configure Visualizations #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
| # Enable different visualizations: True or False (refer viz.py) | ||
| # --------------------------------------------------- | ||
|
|
||
| VIZ_TYPES = { |
There was a problem hiding this comment.
I'd rather go with a blacklist so that we don't have to touch this everytime we add a new viz, probably should just be a tuple of viz_types
|
@mistercrunch sounds good. Fixed and tested. |
|
|
|
|
| @@ -14,7 +14,6 @@ | |||
| import uuid | |||
| from collections import OrderedDict, defaultdict | |||
| from datetime import datetime, timedelta | |||
|
|
|||
There was a problem hiding this comment.
I'll merge anyways, but the idea for that blank line is to differentiate between standard lib imports and external ones. It matters most in large modules with lots of imports...
|
Thanks for the PR! |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* docs: update storybook * fix: import * fix: import * fix: import
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* docs: update storybook * fix: import * fix: import * fix: import
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…he#365) Bumps [@airbnb/config-eslint](https://github.com/airbnb/nimbus) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/airbnb/nimbus/releases) - [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-eslint@2.5.1...@airbnb/config-eslint@2.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* docs: update storybook * fix: import * fix: import * fix: import
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…he#365) Bumps [@airbnb/config-eslint](https://github.com/airbnb/nimbus) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/airbnb/nimbus/releases) - [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-eslint@2.5.1...@airbnb/config-eslint@2.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* docs: update storybook * fix: import * fix: import * fix: import
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…he#365) Bumps [@airbnb/config-eslint](https://github.com/airbnb/nimbus) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/airbnb/nimbus/releases) - [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-eslint@2.5.1...@airbnb/config-eslint@2.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* docs: update storybook * fix: import * fix: import * fix: import
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…he#365) Bumps [@airbnb/config-eslint](https://github.com/airbnb/nimbus) from 2.5.1 to 2.5.2. - [Release notes](https://github.com/airbnb/nimbus/releases) - [Changelog](https://github.com/airbnb/nimbus/blob/master/CHANGELOG.md) - [Commits](https://github.com/airbnb/nimbus/compare/@airbnb/config-eslint@2.5.1...@airbnb/config-eslint@2.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we want to be able to enable/disable visualizations because rarely all them are applicable to a given data distribution. Users can now see only selected viz based on the configuration done by admin in config.py