chore: Empty state refactor #31860
Open
chore: Empty state refactor #31860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Korbit doesn't automatically review large (500+ lines changed) pull requests such as this one. If you want me to review anyway, use |
geido
reviewed
Jan 15, 2025
| @@ -113,7 +113,7 @@ const SqlEditorLeftBar = ({ | |||
| 'schema', | |||
| ]); | |||
|
|
|||
| const [emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false); | |||
| const [_emptyResultsWithSearch, setEmptyResultsWithSearch] = useState(false); | |||
There was a problem hiding this comment.
I think we need setEmptyResultsWithSearch, and are flushing position 1 of the array. Code is a bit cryptic to me here. Not sure why we need setEmptyResultsWithSearch
- making `size` a prop instead of one-component-per-size - fixing up the svg so its themable using `currentColor` - centralizing/fixing up references
mistercrunch
force-pushed
the
refactor_empty
branch
from
0b2a217 to
5640c74
Compare
|
/testenv up |
|
@mistercrunch Processing your ephemeral environment request here. |
|
@mistercrunch Ephemeral environment spinning up at http://54.186.90.161:8080. Credentials are |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizea prop instead of one-component-per-sizecurrentColor