Caravel no data returned exception #314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to caravel_fix_datetime_formating
…brian/panoramix into caravel_fix_datetime_formating
…to caravel_no_data_returned # Conflicts: # caravel/viz.py
|
I think you need to rebase |
added 4 commits
April 10, 2016 09:09
…panoramix into caravel_no_data_returned # Conflicts: # caravel/viz.py
|
Rebased. |
|
This PR isn't right (attempting to delete files) reopen it when it's cleaned up |
|
Ouch! Seems I did something wrong during "re-base" operation. |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Bumps [mustache](https://github.com/janl/mustache.js) from 3.2.1 to 4.0.0. - [Release notes](https://github.com/janl/mustache.js/releases) - [Changelog](https://github.com/janl/mustache.js/blob/master/CHANGELOG.md) - [Commits](janl/mustache.js@v3.2.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Bumps [mustache](https://github.com/janl/mustache.js) from 3.2.1 to 4.0.0. - [Release notes](https://github.com/janl/mustache.js/releases) - [Changelog](https://github.com/janl/mustache.js/blob/master/CHANGELOG.md) - [Commits](janl/mustache.js@v3.2.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Bumps [mustache](https://github.com/janl/mustache.js) from 3.2.1 to 4.0.0. - [Release notes](https://github.com/janl/mustache.js/releases) - [Changelog](https://github.com/janl/mustache.js/blob/master/CHANGELOG.md) - [Commits](janl/mustache.js@v3.2.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Bumps [mustache](https://github.com/janl/mustache.js) from 3.2.1 to 4.0.0. - [Release notes](https://github.com/janl/mustache.js/releases) - [Changelog](https://github.com/janl/mustache.js/blob/master/CHANGELOG.md) - [Commits](janl/mustache.js@v3.2.1...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Not sure if you are interested by I've changed a bit the way "No results" is managed.
I've kept as an exception but created new one
NoResultsException, excpetion is returned in a custom header.Changed the way visualizations notifies error, now they are passing the error object instead only the message.
Finally message is render with another class.