Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): add missing bracket in openID config #30885

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

samarsrivastav
Copy link
Contributor

@samarsrivastav samarsrivastav commented Nov 9, 2024

fix #30673 lMissing Bracket in config.py

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: fixes Bug Report: Missing Bracket in config.py for OpenID Providers #30673
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@samarsrivastav samarsrivastav changed the title Fix Bug #30673 fix: Bug #30673 Missing Bracket in config.py Nov 9, 2024
@sfirke sfirke changed the title fix: Bug #30673 Missing Bracket in config.py Fix(docs): add missing bracket in openID config Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.92%. Comparing base (76d897e) to head (6f00e51).
Report is 955 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #30885       +/-   ##
===========================================
+ Coverage   60.48%   83.92%   +23.43%     
===========================================
  Files        1931      536     -1395     
  Lines       76236    38924    -37312     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32666    -13448     
+ Misses      28017     6258    -21759     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.86% <ø> (-0.31%) ⬇️
javascript ?
mysql 76.78% <ø> (?)
postgres 76.88% <ø> (?)
presto 53.34% <ø> (-0.46%) ⬇️
python 83.92% <ø> (+20.43%) ⬆️
sqlite 76.34% <ø> (?)
unit 60.88% <ø> (+3.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfirke sfirke changed the title Fix(docs): add missing bracket in openID config fix(docs): add missing bracket in openID config Nov 9, 2024
@sfirke sfirke merged commit 24b8a94 into apache:master Nov 9, 2024
46 of 49 checks passed
@sfirke
Copy link
Member

sfirke commented Nov 9, 2024

Thanks @samarsrivastav !

nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Missing Bracket in config.py for OpenID Providers
2 participants