Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(FilterBar): Filter bar accessibility #30812

Merged
merged 1 commit into from
Nov 7, 2024
Merged

chore(FilterBar): Filter bar accessibility #30812

merged 1 commit into from
Nov 7, 2024

Conversation

alexandrusoare
Copy link
Contributor

@alexandrusoare alexandrusoare commented Nov 1, 2024 •
edited by geido
Loading

SUMMARY

Refactored the relationship between labels and their form controls in the filterBar

Fixes #25859

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the design:accessibility Related to accessibility standards label Nov 1, 2024
@geido geido added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold! On hold labels Nov 1, 2024
@geido
Copy link
Member

geido commented Nov 1, 2024

/testenv up

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

@geido Ephemeral environment spinning up at http://54.190.129.182:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@villebro villebro changed the title refactor(FilterBar): Filter bar accessibility chore(FilterBar): Filter bar accessibility Nov 1, 2024
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Nov 1, 2024
@geido geido removed the hold! On hold label Nov 7, 2024
@geido geido merged commit 5b2f005 into apache:master Nov 7, 2024
38 of 43 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Ephemeral environment shutdown and build artifacts deleted.

nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@alexandrusoare @nyohasstium
chore(FilterBar): Filter bar accessibility (apache#30812)
948c603
betodealmeida pushed a commit that referenced this pull request Jan 14, 2025
@alexandrusoare @sadpandajoe
chore(FilterBar): Filter bar accessibility (#30812)
8a016fc 
(cherry picked from commit 5b2f005)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina michael-s-molina is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
design:accessibility Related to accessibility standards preset:bounty Issues that have been selected by Preset and have a bounty attached. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility: Associate label with form control on dashboard filters
3 participants
@alexandrusoare @geido @michael-s-molina