Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Python 3.11 images to Docker Hub #30733

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

padbk
Copy link
Contributor

@padbk padbk commented Oct 28, 2024

SUMMARY

Closes #30672

The aim of this PR is to add python 3.11 images to Docker Hub.

TESTING INSTRUCTIONS

Is it possible to push this branch to Docker Hub to see if the py311 image is created?

@github-actions github-actions bot added the github_actions Pull requests that update GitHub Actions code label Oct 28, 2024
@dosubot dosubot bot added the install:docker Installation - docker container label Oct 28, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@padbk padbk changed the title Add Python 3.11 images to Docker Hub ci: Add Python 3.11 images to Docker Hub Oct 28, 2024
@mistercrunch
Copy link
Member

Ok this only runs on the master branch, so trying to force run it here prior to merging. Let me pull/push the branch and see if I can trigger with the gh workflow command

@michael-s-molina michael-s-molina added the review:checkpoint Last PR reviewed during the daily review standup label Oct 28, 2024
@mistercrunch
Copy link
Member

mistercrunch commented Oct 28, 2024

Copy link
Member

@mistercrunch mistercrunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in another branch, looks like docker build runs ok on 3.11. Before I merge, @padbk can you pull the image and confirm 1. it's running 3.11 and 2. it's working properly

@padbk
Copy link
Contributor Author

padbk commented Oct 29, 2024

Thank you for your help @mistercrunch

Unfortunately there looks to be a couple of issue here:
For the build, it is still using PY_VER=3.10-slim-bookworm:
https://github.com/apache/superset/actions/runs/11563861551/job/32187975853
I assumed it would make use of this logic below, but looking at the build above now, I don't think it does?

elif build_preset == "py311":

And even though it completed successfully, I cannot see a python 3.11 image on Docker Hub for that commit:
https://hub.docker.com/r/apache/superset/tags?name=1bad12c

@padbk
Copy link
Contributor Author

padbk commented Oct 29, 2024

Realised it actually runs a script in another repo:
https://github.com/apache-superset/supersetbot/blob/main/src/docker.js

So made a PR to change that too:
apache-superset/supersetbot#3

🙏

@mistercrunch mistercrunch merged commit eecb537 into apache:master Oct 29, 2024
36 of 37 checks passed
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 29, 2024
sadpandajoe pushed a commit that referenced this pull request Oct 31, 2024
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Oct 31, 2024
@github-actions github-actions bot added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code install:docker Installation - docker container size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Python 3.11 images on DockerHub
4 participants