-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable suppressing default chart context menu #30613
Conversation
@kgabryje Can you explain a little bit more about the intention of this PR? Currently, disabled options are greyed out by default but you're trying to completely suppress the menu, which might lead to users asking why right click is not working. Could you explain what's the use case you're trying to solve? |
The intention is so that a viz plugin can define it's own, fully custom context menu. For example, the viz plugin could have a context menu with more actions, specific to this plugin. |
I recommend adding a comment to the property explaining the use as it can be easily removed. This also raises the question if this shouldn't be an extension to be more explicit. |
@michael-s-molina Added a comment. I believe this change fits in Superset - for instance, it would be useful if in the future we wanted to improve the table viz plugin by adding more table-related actions to the context menu. Currently it's not possible as we are limited by the context menu defined in ChartRenderer which is the same for every plugin. |
(cherry picked from commit 47c5334)
SUMMARY
Add a config option to chart metadata to allow suppressing the default chart context menu on the dashboard (the one with the default cross filter and drill to detail menu items)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION