Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve DML check #30417

Merged
merged 1 commit into from
Sep 27, 2024
Merged

chore: improve DML check #30417

merged 1 commit into from
Sep 27, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Small improvement: only check for DDL/DML in SQL Lab when the feature is disabled in the DB. This way we don't need to parse the query unnecessarily.

Also bump sqlglot.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the sqllab Namespace | Anything related to the SQL Lab label Sep 27, 2024
@betodealmeida betodealmeida force-pushed the improve-dml-check branch 2 times, most recently from 8208a4a to 4b74ebf Compare September 27, 2024 16:29
@michael-s-molina
Copy link
Member

@betodealmeida Can you add the sqlglot CHANGELOG to the PR description to help reviewers?

@michael-s-molina
Copy link
Member

@betodealmeida I noticed that there are many breaking changes between 23.0 and 25.24. Can any of these affect us?

@betodealmeida
Copy link
Member Author

@betodealmeida I noticed that there are many breaking changes between 23.0 and 25.24. Can any of these affect us?

As far as I can tell, no. The breaking changes are either breaking internal APIs (which we don't rely heavily on), or breaking behavior that was previously incorrect.

@betodealmeida betodealmeida merged commit cc9fd88 into master Sep 27, 2024
33 checks passed
@rusackas rusackas deleted the improve-dml-check branch September 27, 2024 20:53
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

Assignees
No one assigned
Labels
size/M sqllab Namespace | Anything related to the SQL Lab v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@betodealmeida @michael-s-molina @dpgaspar @sadpandajoe