Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(View): Remove unnecessary theme view and defer basic styles #30128

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

geido
Copy link
Member

@geido geido commented Sep 2, 2024

SUMMARY

Removes unnecessary theme view and defers styles in basic.html

TESTING INSTRUCTIONS

  1. UI should work as normal

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido requested a review from kgabryje September 2, 2024 14:01
@github-actions github-actions bot added the api Related to the REST API label Sep 2, 2024
@dosubot dosubot bot added the change:frontend Requires changing the frontend label Sep 2, 2024
@apache apache deleted a comment from github-actions bot Sep 2, 2024
@geido
Copy link
Member Author

geido commented Sep 2, 2024

/testenv up

Copy link
Contributor

github-actions bot commented Sep 2, 2024

@geido Ephemeral environment spinning up at http://35.87.80.58:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje
Copy link
Member

kgabryje commented Sep 3, 2024

It looks like the rels were not swapped

image

@geido
Copy link
Member Author

geido commented Sep 3, 2024

http://35.87.80.58:8080

Weirdly enough they look swapped to me on the ephemeral

Screenshot 2024-09-03 at 18 13 09

@kgabryje
Copy link
Member

kgabryje commented Sep 3, 2024

http://35.87.80.58:8080

Weirdly enough they look swapped to me on the ephemeral

Do ephemeral envs use a dev build? Because it probably only works because of more loose CSP config.
In prod there’s a CSP error because the script doesn’t have a nonce

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an unanswered question on the thread, but I don't see it as blocking. LG(enough)TM ❤️ 🚀

@apache apache deleted a comment from github-actions bot Sep 27, 2024
@geido
Copy link
Member Author

geido commented Sep 27, 2024

/testenv up

Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.218.85.71:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 4ac0bb1 into master Sep 27, 2024
33 checks passed
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@rusackas rusackas deleted the geido/chore/remove-unnecessary-styles branch September 27, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Related to the REST API change:frontend Requires changing the frontend size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants