Fix week and month Time grain in MySQL #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With mysql datetime and timestamp columns, currently the Time grain "week" and "month" options don't remove the time part. This results in groupings like this: timestamp count 2015-04-05 07:00:00 1 2015-04-05 10:00:00 1 2015-04-05 11:00:00 2 2015-04-05 11:50:00 1 2015-04-05 12:00:00 5 2015-04-05 14:20:00 1 2015-04-05 14:30:00 1 and so on. This is solved by wrapping the DATE_SUB with DATE().
|
Good catch |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.194...v0.0.195) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.194...v0.0.195) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.194...v0.0.195) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.194...v0.0.195) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Bumps [@vx/responsive](https://github.com/hshoff/vx) from 0.0.194 to 0.0.195. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.194...v0.0.195) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
This was referenced Apr 5, 2022
This was referenced Jul 8, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mysql datetime and timestamp columns, currently the Time grain "week" and "month" options don't remove the time part. This results in groupings like this:
timestamp count
2015-04-05 07:00:00 1
2015-04-05 10:00:00 1
2015-04-05 11:00:00 2
2015-04-05 11:50:00 1
2015-04-05 12:00:00 5
2015-04-05 14:20:00 1
2015-04-05 14:30:00 1
and so on.
This is solved by wrapping the DATE_SUB with DATE().