Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show_filters URL parameter is not working #29422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hexcafe
Copy link
Contributor

@hexcafe hexcafe commented Jul 1, 2024

SUMMARY

Problem:
When embedding the dashboard, the filter panel does not hide even when show_filters is set to false.
After a quick investigation, I found that this parameter is not being handled at all.

Expected Behavior:

  • By default, the filter panel will be shown.
  • The filter panel should be hidden if the show_filters parameter is explicitly set to false or 0.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dosubot dosubot bot added dashboard Namespace | Anything related to the Dashboard dashboard:native-filters Related to the native filters of the Dashboard labels Jul 1, 2024
@rusackas rusackas requested review from kgabryje and Vitor-Avila July 1, 2024 16:49
@Vitor-Avila
Copy link
Contributor

Thanks for the PR, @hexcafe. Hey @michael-s-molina @john-bodley,
I believe this is a continuation of #25804 which was aiming to fix #24195 (used to work until #23228).

I checked out this PR locally and tested and it works ✅ but since I'm just getting familiar with frontend I wanted to get your thoughts.

I didn't think so, but this also works with the horizontal filter bar 🙌

Thanks!

@michael-s-molina
Copy link
Member

@hexcafe @Vitor-Avila Shouldn't we just revert this part that was deleted in #23228?

@RoBYCoNTe
Copy link

Any news about this PR?

@grzaks
Copy link

grzaks commented Oct 5, 2024

Would be great to see this one merged into next release.

@nawar
Copy link

nawar commented Oct 28, 2024

Can we please get this reviewed?

@Vitor-Avila
Copy link
Contributor

@michael-s-molina would you prefer to have that code block restored as opposed to using the approach in this PR?

@michael-s-molina
Copy link
Member

@michael-s-molina would you prefer to have that code block restored as opposed to using the approach in this PR?

@Vitor-Avila It seems we should restore that code given that nativeFiltersEnabled, which is used for many things when calculating the dashboard state, used to depend on that parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:native-filters Related to the native filters of the Dashboard dashboard Namespace | Anything related to the Dashboard size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants