fix(dashboard): overload issue in dashboard export to excel

[mcdogg17]

SUMMARY

Removed the redundant call for fetching Slice objects, which was causing significant increases in load times for large dashboards (approximately 500 slices).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[mcdogg17]

@supersetbot orglabel

[rusackas]

LGTM, but I'd be more comfortable merging with a second opinion. Pinging more :)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (76d897e) to head (35b1902).
Report is 396 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #29418       +/-   ##
===========================================
+ Coverage   60.48%   83.89%   +23.40%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37470    -38766     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31435    -14679     
+ Misses      28017     6035    -21982     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	49.10% <0.00%> (-0.06%)	⬇️
javascript	?
mysql	77.44% <100.00%> (?)
postgres	77.52% <100.00%> (?)
presto	53.72% <50.00%> (-0.08%)	⬇️
python	83.89% <100.00%> (+20.40%)	⬆️
sqlite	77.00% <100.00%> (?)
unit	59.64% <0.00%> (+2.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rusackas]

This looks like it just needs some linting help to get through. Installing/running the pre-commit hook should do it.

[rusackas]

https://superset.apache.org/docs/contributing/development/#git-hooks-1

[mcdogg17]

@rusackas
Hi! I'm sorry for the long answer. I installed a pre-commit and pushed the changes. Everything should be fine now.