Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trigger CI jobs on all release-related branches #29274

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

mistercrunch
Copy link
Member

SUMMARY

Currently, we trigger the bulk of our CI on all PRs, and on push to the master and release branches.

Release branches currently are defined as [0-9].[0-9] meaning it will work for 3.5 and 10.10, but not for 3.1.1, 3.0-beta2 or whatever other release branch that don't fit the "minor" release pattern.

Not I'm extending this to [0-9].[0-9]*. As a glob that mean it'll run for practically anything that loosely looks like a release branch.

The goal is to make it easier for people working in forks, whether private or public to trigger CI while doing their own release management. Currently if you want to trigger CI, you pretty much to either open a dummy PR, or push to a branch that fits the current pattern, which doesn't allow for flexibility around branch naming, which is key for release management.

This PR should not affect the repo or release process on this repo, it's just about making it easier to trigger CI on forks.

Currently, we trigger the bulk of our CI on all PRs, and on push to the `master` and release branches.

Release branches currently are defined as `[0-9].[0-9]` meaning it will work for `3.5` and `10.10`, but not for `3.1.1`, `3.0-beta2` or whatever other release branch that don't fit the "minor" release pattern.

Not I'm extending this to `[0-9].[0-9]*`. As a glob that mean it'll run for practically anything that loosely looks like a release branch.

The goal is to make it easier for people working in forks, whether private or public to trigger CI while doing their own release management. Currently if you want to trigger CI, you pretty much to either open a dummy PR, or push to a branch that fits the current pattern, which doesn't allow for flexibility around branch naming, which is key for release management.

This PR should not affect the repo or release process on this repo, it's just about making it easier to trigger CI on forks.
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jun 17, 2024
@mistercrunch mistercrunch merged commit d49d791 into master Jun 17, 2024
34 checks passed
@rusackas rusackas deleted the ci_on_release branch June 17, 2024 22:21
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants