Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mariadb engine spec same as MySQL #27919

Merged
merged 1 commit into from
Apr 5, 2024
Merged

fix: add mariadb engine spec same as MySQL #27919

merged 1 commit into from
Apr 5, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 5, 2024

SUMMARY

MariaDB is a fork of MySQL, although the two developments are diverging, the dialect remains practically the same. This PR adds our customization of MySQL to MariaDB so that it can benefit from a good experience in Superset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar merged commit 559605e into apache:master Apr 5, 2024
41 of 42 checks passed
@dpgaspar dpgaspar deleted the fix/add-mariadb-eng-spec branch April 5, 2024 09:41
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Apr 5, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
@dpgaspar @EandrewJones
fix: add mariadb engine spec same as MySQL (apache#27919)
ce4653a
michael-s-molina pushed a commit that referenced this pull request Apr 8, 2024
@dpgaspar @michael-s-molina
fix: add mariadb engine spec same as MySQL (#27919)
cb39fcd 
(cherry picked from commit 559605e)
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
@dpgaspar @EnxDev
fix: add mariadb engine spec same as MySQL (apache#27919)
25c8d28
michael-s-molina pushed a commit that referenced this pull request Apr 16, 2024
@dpgaspar @michael-s-molina
fix: add mariadb engine spec same as MySQL (#27919)
d71bad7 
(cherry picked from commit 559605e)
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
@dpgaspar @qleroy
fix: add mariadb engine spec same as MySQL (apache#27919)
bf043af
@mistercrunch mistercrunch added 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@villebro villebro Awaiting requested review from villebro

@betodealmeida betodealmeida Awaiting requested review from betodealmeida

@michael-s-molina michael-s-molina Awaiting requested review from michael-s-molina

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 3.1.3 🍒 4.0.1 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpgaspar @geido @mistercrunch @michael-s-molina