Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: extend user email size #25053

Merged
merged 5 commits into from
Aug 22, 2023
Merged

fix: extend user email size #25053

merged 5 commits into from
Aug 22, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Aug 22, 2023 •
edited
Loading

SUMMARY

Flask-AppBuilder 4.3.6 extends user email from 64 to 320 correctly following RFC 5321:

64 Local part +1 (@) + 255 Domain = 320

This PR makes the necessary migration on Superset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from a team as a code owner August 22, 2023 12:30
@dpgaspar dpgaspar changed the title Test/4.3.6rc1 fix: extend user email size Aug 22, 2023
michael-s-molina
michael-s-molina approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 6975084 into apache:master Aug 22, 2023
@dpgaspar dpgaspar deleted the test/4.3.6rc1 branch August 22, 2023 13:52
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 22, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 23, 2023
@dpgaspar @michael-s-molina
fix: extend user email size (#25053)
6003aa2 
(cherry picked from commit 6975084)
@john-bodley john-bodley mentioned this pull request Aug 29, 2023
Merged
9 tasks
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@dpgaspar
fix: extend user email size (apache#25053)
07272c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @michael-s-molina @mistercrunch