Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate FLASK_ENV and improve conf.ENVIRONMENT_TAG_CONFIG #24404

Merged
merged 10 commits into from
Jun 29, 2023
Prev Previous commit
Next Next commit
addressing comments
mistercrunch committed Jun 16, 2023
commit 58beff409364a05a4c2083a24dd66725d50f58be
4 changes: 2 additions & 2 deletions superset/views/base.py
Original file line number Diff line number Diff line change
@@ -335,10 +335,10 @@ def render_app_template(self) -> FlaskResponse:

def get_environment_tag() -> dict[str, Any]:
# Whether flask is in debug mode (--debug)
debug = appbuilder.app.config.get("DEBUG")
debug = appbuilder.app.config["DEBUG"]

# Getting the configuration option for ENVIRONMENT_TAG_CONFIG
env_tag_config = appbuilder.app.config.get("ENVIRONMENT_TAG_CONFIG")
env_tag_config = appbuilder.app.config["ENVIRONMENT_TAG_CONFIG"]

# These are the predefined templates define in the config
env_tag_templates = env_tag_config.get("values")