Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated api /superset/available_domains #24381

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

Removes deprecated API /superset/available_domains/

Effort on removing deprecated API from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #24381 (5c33142) into master (93ba59d) will increase coverage by 0.57%.
The diff coverage is n/a.

❗ Current head 5c33142 differs from pull request most recent head 184469c. Consider uploading reports for the commit 184469c to get more accurate results

@@            Coverage Diff             @@
##           master   #24381      +/-   ##
==========================================
+ Coverage   68.36%   68.94%   +0.57%     
==========================================
  Files        1903     1903              
  Lines       74385    74378       -7     
  Branches     8110     8110              
==========================================
+ Hits        50856    51279     +423     
+ Misses      21417    20987     -430     
  Partials     2112     2112              
Flag Coverage Δ
hive ?
mysql 79.38% <ø> (?)
postgres 79.44% <ø> (?)
presto 53.81% <ø> (-0.01%) ⬇️
python 83.16% <ø> (+1.19%) ⬆️
sqlite ?
unit 54.30% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.64% <ø> (+0.23%) ⬆️

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar merged commit c04bd4c into apache:master Jun 13, 2023
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-10 branch June 13, 2023 09:19
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants