-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove user registrations menu for non-admins #24198
chore: remove user registrations menu for non-admins #24198
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24198 +/- ##
==========================================
+ Coverage 67.27% 68.98% +1.70%
==========================================
Files 1903 1903
Lines 74275 74275
Branches 8110 8110
==========================================
+ Hits 49971 51241 +1270
+ Misses 22192 20922 -1270
Partials 2112 2112
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 104 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@villebro Could you include something in |
Good idea @michael-s-molina - there may be a small change forthcoming in FAB that requires me to add one more line to this diff, so I'm waiting for confirmation on this from @dpgaspar before proceeding |
3dd81f3
to
a62a120
Compare
a62a120
to
664235a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUMMARY
Currently only Admins have "menu access on Security", but despite that, non-admins have "menu access on User's Statistics" and "menu access on "User Registrations" which belong under the "Security" menu. This removes menu access, as they aren't really able to access the menu. We also bump FAB to the lastest version, which includes a fix to the "User Registrations" view registration: dpgaspar/Flask-AppBuilder#2051
AFTER
After the change, a Gamma user with Alerts & Reports and RLS access will only see the RLS menu under Security:
BEFORE
Previously, they would also see the User Registrations menu:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION