chore: Update QUERY_LOGGER and SQL_QUERY_MUTATOR signatures

[john-bodley]

SUMMARY

This PR addresses Superset 3.0 task #45.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24029 (c7be3d5) into master (e856e35) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c7be3d5 differs from pull request most recent head 86eaed5. Consider uploading reports for the commit 86eaed5 to get more accurate results

@@            Coverage Diff             @@
##           master   #24029      +/-   ##
==========================================
- Coverage   68.30%   68.30%   -0.01%     
==========================================
  Files        1952     1952              
  Lines       75432    75431       -1     
  Branches     8191     8191              
==========================================
- Hits        51521    51520       -1     
  Misses      21807    21807              
  Partials     2104     2104              

Flag	Coverage Δ
hive	53.17% <100.00%> (-0.01%)	⬇️
mysql	78.94% <100.00%> (-0.01%)	⬇️
postgres	79.01% <100.00%> (-0.01%)	⬇️
presto	53.09% <100.00%> (-0.01%)	⬇️
python	82.81% <100.00%> (-0.01%)	⬇️
sqlite	77.54% <100.00%> (-0.01%)	⬇️
unit	53.09% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	92.02% <ø> (ø)
superset/models/core.py	89.95% <ø> (-0.03%)	⬇️
superset/models/helpers.py	69.83% <ø> (ø)
superset/sql_lab.py	86.41% <ø> (ø)
superset/connectors/sqla/models.py	89.77% <100.00%> (ø)
superset/db_engine_specs/base.py	90.82% <100.00%> (ø)
superset/sql_validators/presto_db.py	82.43% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

Thank you for the cleanup @john-bodley. I left a comment but other then that LGTM.

[michael-s-molina]

Could you move this to the Breaking Changes section?

[eschutho]

@john-bodley I'm just tagging this with risk:breaking-change for anyone that might be overriding the config.

[eschutho]

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

[michael-s-molina]

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

Definitely. I think there was a miscommunication in the review because there's breaking change text added in this PR but it seems it's not related to the particular change.

[michael-s-molina]

@michael-s-molina should we put something in the UPDATING file for 3.0 on this, too? This broke our integration, so maybe having the change in updating could help other people upgrading as well b/c they will have to import the user into their config overwrite from global now.

@eschutho @john-bodley I added the breaking change text here.