Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecates 3.0 consented feature flags #23785

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Deprecates the following feature flags that received lazy consensus for 3.0:

  • CLIENT_CACHE
  • DASHBOARD_CACHE
  • DASHBOARD_FILTERS_EXPERIMENTAL
  • DASHBOARD_NATIVE_FILTERS
  • DASHBOARD_NATIVE_FILTERS_SET
  • DISABLE_DATASET_SOURCE_EDIT
  • ENABLE_EXPLORE_JSON_CSRF_PROTECTION
  • REMOVE_SLICE_LEVEL_LABEL_COLORS

DASHBOARD_EDIT_CHART_IN_NEW_TAB was removed as the feature is supported without the need for a feature flag.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina marked this pull request as ready for review April 23, 2023 17:08
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #23785 (8244ed6) into master (09bd40b) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8244ed6 differs from pull request most recent head 8d0b459. Consider uploading reports for the commit 8d0b459 to get more accurate results

@@           Coverage Diff           @@
##           master   #23785   +/-   ##
=======================================
  Coverage   68.02%   68.03%           
=======================================
  Files        1936     1936           
  Lines       74930    74926    -4     
  Branches     8141     8137    -4     
=======================================
- Hits        50974    50973    -1     
+ Misses      21870    21868    -2     
+ Partials     2086     2085    -1     
Flag Coverage Δ
hive 53.00% <ø> (ø)
mysql 78.80% <ø> (ø)
postgres 78.87% <ø> (ø)
presto 52.92% <ø> (ø)
python 82.67% <ø> (ø)
sqlite 77.39% <ø> (ø)
unit 52.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 56.48% <ø> (+1.02%) ⬆️
...ntend/src/dashboard/util/getSliceHeaderTooltip.tsx 83.33% <ø> (+8.33%) ⬆️
superset/config.py 91.88% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina force-pushed the deprecated-feature-flags-3-0 branch from 2ff4626 to 88cda77 Compare April 23, 2023 17:20
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the cleanup! Now I'm excited for 4.0 as much as 3.0 :)

@michael-s-molina michael-s-molina force-pushed the deprecated-feature-flags-3-0 branch from 88cda77 to 8d0b459 Compare April 26, 2023 11:56
@michael-s-molina michael-s-molina merged commit aa2edfc into apache:master Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@wdepiatti
Copy link

I have a problem with the native filter that disappears, when I use docker-compose-image-tag.yml, the version is 3.1.1
. But... when I run docker-compose-non-dev.yml, version 0.0.0-dev and native filters appear, I've already carried out a search, I can't activate the filter in version 3.1.1

000dev
311v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants