Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reports): change default executor to owner #22799

Merged
merged 4 commits into from
May 17, 2023

Conversation

villebro
Copy link
Member

SUMMARY

This changes Alerts & Reports to execute as the primary owner of the alert/report by default. In cases where there are multiple owners, the last modifier and creator are given priority in this order, otherwise the first owner will be used. This option was introduced in #21931.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #22799 (74743b4) into master (357745f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 74743b4 differs from pull request most recent head 2d6a74d. Consider uploading reports for the commit 2d6a74d to get more accurate results

@@           Coverage Diff           @@
##           master   #22799   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files        1951     1951           
  Lines       75385    75385           
  Branches     8185     8185           
=======================================
  Hits        51496    51496           
  Misses      21786    21786           
  Partials     2103     2103           
Flag Coverage Δ
hive 53.19% <100.00%> (ø)
mysql 78.96% <100.00%> (ø)
postgres 79.03% <100.00%> (ø)
presto 53.12% <100.00%> (ø)
python 82.83% <100.00%> (ø)
sqlite 77.55% <100.00%> (ø)
unit 53.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 92.02% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 20, 2023
@villebro villebro changed the title chore(reports): change default executor chore(reports): change default executor to owner Jan 20, 2023
@eschutho eschutho requested a review from hughhhh January 20, 2023 18:42
@rusackas rusackas requested a review from eschutho January 26, 2023 07:24
@eschutho
Copy link
Member

eschutho commented Feb 3, 2023

@villebro This is great, and we're looking forward to testing it out. I assume that this is a 3.0 chore, and we should merge this when the branch opens up for breaking changes, but if someone wants to test out the functionality now, they would only need to change this config? ALERT_REPORTS_EXECUTE_AS: List[ExecutorType] = [ExecutorType.OWNER]

@villebro
Copy link
Member Author

villebro commented Feb 3, 2023

@villebro This is great, and we're looking forward to testing it out. I assume that this is a 3.0 chore, and we should merge this when the branch opens up for breaking changes, but if someone wants to test out the functionality now, they would only need to change this config? ALERT_REPORTS_EXECUTE_AS: List[ExecutorType] = [ExecutorType.OWNER]

@eschutho Yes, I think it's a good idea to slot this for 3.0. I'll tag it accordingly. And by changing the config as as proposed above you can opt in to this behavior.

@villebro villebro added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Feb 3, 2023
@villebro villebro force-pushed the villebro/alerts-default branch from fa71238 to 71b87c9 Compare February 3, 2023 07:02
@rusackas rusackas requested a review from john-bodley April 15, 2023 04:09
@rusackas
Copy link
Member

If this is considered breaking, we should put it on the 3.0 project board and seek lazy consensus. The merge window is open!

Comment on lines +54 to +55
- [23651](https://github.com/apache/superset/pull/23651): Removes UX_BETA feature flag.
- [23663](https://github.com/apache/superset/pull/23663): Removes deprecated feature flags `ALLOW_DASHBOARD_DOMAIN_SHARDING`, `DISPLAY_MARKDOWN_HTML`, and `FORCE_DATABASE_CONNECTIONS_SSL`.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bycatch: the colon was missing after the link

@villebro villebro merged commit 5192925 into apache:master May 17, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants