Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tabs to edit dataset page #22043

Merged
merged 20 commits into from
Feb 3, 2023
Merged

feat: add tabs to edit dataset page #22043

merged 20 commits into from
Feb 3, 2023

Commits on Feb 1, 2023

  1. feat: add tabs to edit dataset page

    @pkdotson @lyndsiWilliams
    pkdotson authored and lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    7b5c1ac View commit details
    Browse the repository at this point in the history

  2. add test, fix css, and add comments

    @pkdotson @lyndsiWilliams
    pkdotson authored and lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3b42fc5 View commit details
    Browse the repository at this point in the history

  3. fix type

    @pkdotson @lyndsiWilliams
    pkdotson authored and lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0b6af23 View commit details
    Browse the repository at this point in the history

  4. Update superset-frontend/src/views/CRUD/data/dataset/AddDataset/EditD… 

    …ataset/EditDataset.test.tsx

Co-authored-by: Lyndsi Kay Williams <55605634+lyndsiWilliams@users.noreply.github.com>
    @AAfghahi @lyndsiWilliams
    AAfghahi and lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3b59aab View commit details
    Browse the repository at this point in the history

  5. Rebase and make usage tab accessible

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    435edca View commit details
    Browse the repository at this point in the history

  6. Address review comments

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    e65b480 View commit details
    Browse the repository at this point in the history

  7. Fix EditDataset test

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    fb08fac View commit details
    Browse the repository at this point in the history

  8. Change naming of TRANSLATED to TRANSLATIONS and add logging

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    3c435f2 View commit details
    Browse the repository at this point in the history

  9. Address review comments

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    b62857c View commit details
    Browse the repository at this point in the history

  10. Fix dataset hooks

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    c47f25d View commit details
    Browse the repository at this point in the history

  11. Add getDatasetRelatedObjects to dependency array

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    1db6c4b View commit details
    Browse the repository at this point in the history

  12. Change casing of usageTab

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    febe947 View commit details
    Browse the repository at this point in the history

  13. Address review comments

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bc436af View commit details
    Browse the repository at this point in the history

  14. Fix AddDataset test by mocking useParams

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    9723a54 View commit details
    Browse the repository at this point in the history

  15. Fix rebase loss

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    786ecd0 View commit details
    Browse the repository at this point in the history

  16. Fix rebase issues

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bbe35c8 View commit details
    Browse the repository at this point in the history

  17. Add function description back to useGetDatasetsList

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8b78b6a View commit details
    Browse the repository at this point in the history

  18. Merge branch 'master' into feat-usage-dataset

    @lyndsiWilliams
    lyndsiWilliams committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    a80c6b5 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Optimize dataset hooks and LeftColumn visibility logic

    @lyndsiWilliams
    lyndsiWilliams committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    c6a9b07 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. remove unneeded return statement

    @lyndsiWilliams
    lyndsiWilliams committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    57ccf2c View commit details
    Browse the repository at this point in the history