Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: logging warning on dataframe (don't use python's warnings) #18111

Merged
merged 2 commits into from
Jan 20, 2022
Merged

fix: logging warning on dataframe (don't use python's warnings) #18111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61a90c4
fix: logging warning on dataframe (don't use python's warnings)
dpgaspar Jan 20, 2022
8ad55f5
lint
dpgaspar Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions superset/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@
# under the License.
""" Superset utilities for pandas.DataFrame.
"""
import warnings
import logging
from typing import Any, Dict, List

import pandas as pd

from superset.utils.core import JS_MAX_INTEGER

logger = logging.getLogger(__name__)


def _convert_big_integers(val: Any) -> Any:
"""
Expand All @@ -43,10 +45,8 @@ def df_to_records(dframe: pd.DataFrame) -> List[Dict[str, Any]]:
:returns: a list of dictionaries reflecting each single row of the DataFrame
"""
if not dframe.columns.is_unique:
warnings.warn(
"DataFrame columns are not unique, some columns will be omitted.",
UserWarning,
stacklevel=2,
logger.warning(
"DataFrame columns are not unique, some columns will be omitted."
)
columns = dframe.columns
return list(
Expand Down