chore: Moves the Menu to views/components folder #17897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17897 +/- ##
==========================================
- Coverage 67.10% 67.10% -0.01%
==========================================
Files 1609 1609
Lines 64897 64895 -2
Branches 6866 6866
==========================================
- Hits 43547 43545 -2
Misses 19484 19484
Partials 1866 1866
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Jan 6, 2022
| import { Tooltip } from 'src/components/Tooltip'; | ||
| import { Link } from 'react-router-dom'; | ||
| import { Row, Col, Grid } from 'antd'; |
rusackas
approved these changes
Jan 6, 2022
shcoderAlex
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 7, 2022
* chore: Moves the Menu to views/components folder * Fixes imports
bwang221
pushed a commit
to casual-precision/superset
that referenced
this pull request
Feb 10, 2022
* chore: Moves the Menu to views/components folder * Fixes imports
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Moves the
Menuto theviews/componentsfolder. This menu is not generic but the one used by the listing views. The generic menu is currently implemented insrc/common/components/index.tsxand it will be moved to thecomponentsfolder in a follow-up PR.This work is part of SIP-61
TESTING INSTRUCTIONS
1 - Execute all tests
2 - All tests should pass
ADDITIONAL INFORMATION