Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix superset cli for python3 #1760

Merged
merged 2 commits into from
Dec 4, 2016
Merged

Fix superset cli for python3 #1760

merged 2 commits into from
Dec 4, 2016

Conversation

xrmx
Copy link
Contributor

@xrmx xrmx commented Dec 4, 2016

While at it avoid cleanup the code a bit.

xrmx added 2 commits December 4, 2016 13:36
dict.iteritems() has been removed since dict.items() returns an
iterable in python3. Shouldn't be a big deal for python2 to load
all the data into a list.

Fix apache#1756
We don't need to unpack and then pack again a dictionary.
@mistercrunch
Copy link
Member

Ooops. Thanks for fixing this.

@mistercrunch mistercrunch merged commit abd0974 into apache:master Dec 4, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants