-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump mysqlclient version #17556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17556 +/- ##
=======================================
Coverage 76.95% 76.96%
=======================================
Files 1049 1049
Lines 56671 56681 +10
Branches 7851 7851
=======================================
+ Hits 43611 43622 +11
+ Misses 12807 12806 -1
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@gnought can you add some context in the description why the bump is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gnought thanks for adding context to the description 👍 I hadn't noticed we had conflicting versions of mysqlclient
on setup.py
and requirements/development.(in|txt)
. As I see some removals/deprecations on the 2.x version, It could be a good idea to add a note to UPDATING.md
to make sure people/orgs that are currently running the 1.x version make sure they make any necessary changes to their connection configs.
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
MySQLClient 1.4.2post1 is quite old, and it's time to update to fix bugs.
v2.1.0 supports multiple statements in default. We could issue
set @T=1; select @T;
whenAllow DML
is true.The change log could refer to https://github.com/PyMySQL/mysqlclient/blob/main/HISTORY.rst
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION