refactor(monorepo): relocate superset-ui #17445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
changed the title
zhaoyongjie
changed the title
This was referenced Nov 16, 2021
ktmud
approved these changes
Nov 17, 2021
ktmud
reviewed
Nov 17, 2021
|
Before merging this PR, we must update .asf.yml to enable "Create merge commit", otherwise it is not possible:
|
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
4 times, most recently
from
5149a63 to
7beb48a
Compare
rusackas
added
hold!
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
from
77baf62 to
511acb1
Compare
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
from
511acb1 to
c597a7f
Compare
Codecov Report
@@ Coverage Diff @@
## master #17445 +/- ##
==========================================
+ Coverage 76.81% 76.95% +0.14%
==========================================
Files 1049 1049
Lines 56671 56671
Branches 7851 7851
==========================================
+ Hits 43529 43611 +82
+ Misses 12889 12807 -82
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
from
c597a7f to
1073f56
Compare
* fix(plugin-chart-echarts): sanitize series from html tags * use echarts html encoder
* chore: bump eslint 5.3.0 * fix lint
* change to prettier.config.js * printWidth to 80 * format * tweak
* feat: remove the default Y-axis truncate in bar chart * make all charts consistently * fix lint
* feat(core): add support for adhoc columns * simplify import * revert simplification due to codecov * fix filter column type * fix pivot v2 groupbys * remove redundant import * Add new type guards * move ColumnMeta type guards to chart-controls * add type guard tests * Fix typing and import errors * Fix saved expression type guard * Fix typing * Remove redundant import * Make Echarts and PivotTable handle AdhocColumns properly * Fix lint Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: John Bodley <john.bodley@airbnb.com>
* chore: coordinate storybook with main repository * update lock file
* chore: end of file fixer * compress image * lint without build * lintrc improvment * exporting * update parallel-coordinates tsconfig * add license to md file * add license * add eslintignore
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
from
1073f56 to
0b54635
Compare
villebro
approved these changes
Nov 26, 2021
kgabryje
reviewed
Nov 26, 2021
9 tasks
zhaoyongjie
force-pushed
the
monorepo_relocate_superset_ui
branch
from
0b54635 to
61a9517
Compare
|
This is really a huge change, it's too friendly for developers, what version will be launched? |
|
We are just about to make a new release cut for 1.5. Finalizing the first release candidate + shipping it usually takes some time, but you should be able to start testing the new release branch within the next few weeks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR MUST wait for monorepo-stage-2 to pass CI.
This PR MUST merged before monorepo-stage-2 .
lerna.jsoninsuperset-frontendworkspacein packages.jsonnpx lerna import --flatten --dest temporary_superset_ui ../../superset-uito import all commits into superset-frontend. commit cut to : apache-superset/superset-ui@3e16995workspacechanging in packages.json (in order not to add new dependencies, dependencies will be added in stage-2 PR)temporary_superset_uiin pre-commit-config*.ipynbfrom .gitignoreTo ensure that every PR passes the CI, the monorepo-related PR is split into multiple stages.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION